publish_release: CI retry on the bump PR cannot clear failed statuses #8
Labels
No labels
auto-update
blocked
dependency
major
release-blocker
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Wi3eDigital/laravel-deploy-actions#8
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
publish_release.yamlin Aevana, kima/portal and slight-exposure retries a failed CI run on the version-bump PR by dispatchingci.yamlon the same branch. Commit status contexts include the trigger (for exampleCI / test (push)), so a dispatched run adds new(workflow_dispatch)statuses next to the failed(push)ones. The combined status of the commit staysfailure, so the retry cannot turn the bump PR green. The flaw predates the rollout.Kardeema (#2218) works around it: a retry closes the bump PR and recreates it as a new commit, so CI runs fresh on a commit without failed statuses.
Plan: https://forgejo.entwirr.me/Wi3eDigital/laravel-deploy-actions/src/branch/main/docs/plan.md
Tasks
(push)statuses in place and the combined state staysfailure.publish_release.yaml, PR #2218) to Aevana, kima/portal and slight-exposure, or move the bump step into a shared action.headfilter), not by scanning the first page of open PRs.Acceptance criteria
Confirmed on Aevana from read-only evidence. The mechanism is slightly different from the issue text:
release/bump-v0.22.0(0609bce): run 4597 failedCI / tests (pull_request)at 22:25. The dispatchedci.yamlruns 4598 (cancelled) and 4599 (success, 22:36) posted no status on the commit at all. The combined state stayedfailureuntil run 4597's own job was re-run by hand at 07:14. That rerun wrote to the same context, the state turnedsuccess, and the publish run was then re-run.release/bump-v0.6.3shows the same: dispatched run 2368 left no status.CI / *(Aevana) andCI /*(slight-exposure).(pull_request), not(push). No(workflow_dispatch)statuses appeared.I ported Kardeema#2218: a retry now closes the bump PR, deletes the branch and rebuilds the bump as a fresh commit. CI is judged from the
CI / <job>contexts only (per-repoCI_JOBS). The PR is found viapulls/main/{head}.All three are merged, so I am closing this issue. Not verified end to end: no release run has gone through the new retry yet.